Re: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, Nov 17, 2015 at 11:27 AM, Opensource [Adam Thomson]
<Adam.Thomson.Opensource@xxxxxxxxxxx> wrote:
> On November 11, 2015 20:20, Rob Herring wrote:
>
>> > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1
>> > +   [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>,
>> <3000>]
>> > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2
>> > +   [<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>,
>> <3000>]
>>
>> Units please (-microvolt).
>
> I refer back to our previous discussion (https://lkml.org/lkml/2015/10/8/661).
> This doesn't add anything and makes the binding name unnecessarily long. Why is
> this being enforced? Whoever uses the binding will have to look at the
> documentation to understand which values are valid anyway, so this seems like
> cruft.

It is simply standard, best practice for new bindings. Certainly there
are examples that don't follow this, but they are either old or
escaped review.

Drop the 'lvl' part if you are so concerned about length.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux