On 2015/11/17 19:28, Ard Biesheuvel wrote:
>> @@ -308,13 +311,18 @@ static int __init arm64_enable_runtime_services(void)
>> > }
>> > set_bit(EFI_SYSTEM_TABLES, &efi.flags);
>> >
>> > - if (!efi_virtmap_init()) {
>> > - pr_err("No UEFI virtual mapping was installed -- runtime services will not be available\n");
>> > - return -1;
>> > - }
>> > + if (!xen_initial_domain()) {
>> > + if (!efi_virtmap_init()) {
>> > + pr_err("No UEFI virtual mapping was installed -- runtime services will not be available\n");
>> > + return -1;
>> > + }
>> >
> I'd prefer it if we could separate the code logically, rather than
> putting xen_initial_domain() tests in all the code paths.
>
> For instance, we could re-use the EFI_PARAVIRT flag, and set if from
> the Xen init code. Then, we could simply test it here, and bail early.
> That way, you can have a Xen specific alternative (which does not use
> the virtmap etc anyway) in a xen source file.
>
Ok, will do. Thanks.
--
Shannon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
