On Mon, Nov 16, 2015 at 04:57:34PM -0800, Laura Abbott wrote: > + for_each_available_child_of_node(dt_node, node) { > + struct platform_device *heap_pdev; > + > + ret = ion_parse_dt_heap_common(node, &heaps[i], compatible); > + if (ret) > + return ERR_PTR(ret); > + > + heap_pdev = of_platform_device_create(node, heaps[i].name, > + &pdev->dev); We should free these if something fails later in the function. > + if (!pdev) > + return ERR_PTR(-ENOMEM); > + heap_pdev->dev.platform_data = &heaps[i]; > + > + heaps[i].priv = &heap_pdev->dev; > + > + ret = ion_setup_heap_common(pdev, node, &heaps[i]); > + if (ret) > + return ERR_PTR(ret); regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html