On 10/24/2013 02:58 AM, Grant Likely wrote: > On Fri, 18 Oct 2013 13:26:51 +0300, Hiroshi Doyu <hdoyu@xxxxxxxxxx> wrote: >> This provides the info about which H/W Accelerators are supported on >> Tegra SoC. This info is passed from DT. This is necessary to have the >> unified SMMU driver among Tegra SoCs. Instead of using platform data, >> DT passes "nvidia,swgroups" now. DT is mandatory in Tegra. >> >> Signed-off-by: Hiroshi Doyu <hdoyu@xxxxxxxxxx> >> --- >> @@ -1200,6 +1193,9 @@ static int tegra_smmu_probe(struct platform_device *pdev) >> if (of_property_read_u32(dev->of_node, "nvidia,#asids", &asids)) >> return -ENODEV; >> >> + if (of_property_read_u64(dev->of_node, "nvidia,swgroups", &swgroups)) >> + return -ENODEV; >> + > > Best practice: A new property has been created here. If the property > isn't present, then it should default to the previous meaning instead of > outright failing. (or make a strong argument that no one is using this > yet and therefore is not breakage). We definitely don't have anyone using this binding yet upstream, and even the reg properties in the DT were wrong for the device, so it couldn't possibly have worked:-( -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
