On Thu, Nov 12, 2015 at 7:26 PM, Rob Herring <robh@xxxxxxxxxx> wrote:
> On Mon, Oct 26, 2015 at 10:24:17PM +0200, Constantine Shulyupin wrote:
>> From: Constantine Shulyupin <const@xxxxxxxxxxxxx>
>> +Optional subnodes:
>> +
>> +Sensor subnodes properties:
>> + - "compatible", allowed values:
>> + - "nuvoton,nct7802"
>
> This should have -sensor appended?
Right.
>> + - "sensor-type", allowed values:
>> + "thermal-diode"
>> + "thermistor"
>> + "voltage"
>> + "local"
>> + "vcore"
>> + "vcc"
>
> These are different connections to the same h/w block in the chip? If
> so, then this is fine. If the h/w blocks are different, then it would be
> better to go back to different compatible strings.
"thermal-diode", "thermistor", "voltage", "local" - is one H/W block
(7.2.32 Mode Selection Register, 22h)
One of above "local" - is single input, enables by one bit EnLTD
"vcore", "vcc" - another H/W block (7.2.35 Voltage Monitor Enable
Register, 25h), each of them is different input.
I'll divide them in the next patch.
>
>> +For sensors of types "thermal-diode", "thermistor" and "voltage" required
>> + - "reg": index in range 0 .. 2
>> +
>> +Except sensor at address 2 can't be "thermal-diode".
>> +
>> +Fan subnode:
>> +
>> +Required properties:
>> + - "reg" :index of in range 0 .. 2.
>
> What does the numbering correspond to in the h/w?
The numberring corresponds to the three different temperature/voltage
inputs (RTD1_MD, RTD2_MD, RTD3_MD) and three different fans (EnFan1,
EnFan2, EnFan3, EnDCFAN*, etc)
>> + vcc {
>> + compatible = "nuvoton,nct7802-sensor";
>> + sensor-type = "vcc";
>
> No unit address?
>
>> + };
>> + vcore {
>> + compatible = "nuvoton,nct7802-sensor";
>> + sensor-type = "vcore";
>> + };
There is only one vcc anv vcore input.
--
Thanks
Constantine
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
