On Wed, 11 Nov 2015 16:26:04 -0800 Brian Norris <computersforpeace@xxxxxxxxx> wrote: > We now stick the device node representing the current MTD (if any) into > sysfs, so let's make sure we have a reference to it before doing that. > > Suggested-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx> Looks good to me, Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> > --- > drivers/mtd/mtdcore.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index a91cee90aef9..c393a1155376 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -32,6 +32,7 @@ > #include <linux/err.h> > #include <linux/ioctl.h> > #include <linux/init.h> > +#include <linux/of.h> > #include <linux/proc_fs.h> > #include <linux/idr.h> > #include <linux/backing-dev.h> > @@ -454,6 +455,7 @@ int add_mtd_device(struct mtd_info *mtd) > mtd->dev.devt = MTD_DEVT(i); > dev_set_name(&mtd->dev, "mtd%d", i); > dev_set_drvdata(&mtd->dev, mtd); > + of_node_get(mtd_get_of_node(mtd)); > error = device_register(&mtd->dev); > if (error) > goto fail_added; > @@ -476,6 +478,7 @@ int add_mtd_device(struct mtd_info *mtd) > return 0; > > fail_added: > + of_node_put(mtd_get_of_node(mtd)); > idr_remove(&mtd_idr, i); > fail_locked: > mutex_unlock(&mtd_table_mutex); > @@ -517,6 +520,7 @@ int del_mtd_device(struct mtd_info *mtd) > device_unregister(&mtd->dev); > > idr_remove(&mtd_idr, mtd->index); > + of_node_put(mtd_get_of_node(mtd)); > > module_put(THIS_MODULE); > ret = 0; -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
