On Friday 06 November 2015 09:55:28 Moritz Fischer wrote: > On Fri, Nov 6, 2015 at 8:42 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Friday 06 November 2015 08:01:25 Moritz Fischer wrote: > >> pins = E31X_TX_BANDSEL_2; > >> output-low; > >> > >> in one .dts, while having something like > >> > >> pins = E33X_TX_BANDSEL_2 > >> output low; > >> > >> in the second dts > > > > That doesn't seem helpful though, because the assignment of the > > pins is not hidden from the source file that should be documenting > > it: if someone wants to know how the pins are muxed, they now have > > to cross-reference the dts file with the header. If you just put the > > pin number directly into the dts, it becomes completely clear > > what the setting is. > > Just to clarify, you're suggesting using "DB_0" etc in the dts file? > At that point > the name becomes kinda useless. I found the PINCTRL_PIN_ANON macro, > but haven't found any use throughout the tree, is using it discouraged? I don't know if that is the best approach, but it's better than using macros here. You should only add a header file with macros if you absolutely have to define a common namespace between the driver and the dts files, but you don't do that here: the header file is only used in one place. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
