Re: [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Luka,

I tested your patch on the GoFlex Home.

+	gpio-leds {
+		compatible = "gpio-leds";
+
+		health {
+			label = "status:green:health";
+			gpios = <&gpio1 14 1>;
+			linux,default-trigger = "default-on";
+		};
+		fault {
+			label = "status:orange:fault";
+			gpios = <&gpio1 15 1>;
+		};
+		misc {
+			label = "status:white:misc";
+			gpios = <&gpio1 8 1>;
+			linux,default-trigger = "ide-disk";
+		};
+	};

I noticed green and orange leds were working fine (0 == off, 1 == on). But white led polarity is inverted (1 == off, 0 == on).

+	partition@500000 {
+		label = "pogoplug";
+		reg = <0x0500000 0x2000000>;
+	};

I don't think pogoplug is the proper label for this partition. It seems duplicated from "kirkwood-goflexnet.dts" I guess you could label it "data" for instance.

Tested-by: Yoann Sculo <yoann@xxxxxxxxx>

Yoann
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux