drivers/mtd/spi-nor/mtk-quadspi.c:223:6-28: Move constant to right. drivers/mtd/spi-nor/mtk-quadspi.c:214:6-10: Move constant to right. Move constants to the right of binary operators. Semantic patch information: Depends on personal taste in some cases. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Bayi Cheng <bayi.cheng@xxxxxxxxxxxx> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx> --- Please take the patch only if it's a positive warning. Thanks! mtk-quadspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/mtd/spi-nor/mtk-quadspi.c +++ b/drivers/mtd/spi-nor/mtk-quadspi.c @@ -211,7 +211,7 @@ static int mt8173_nor_write_buffer_enabl */ writel(MTK_NOR_WR_BUF_ENABLE, mt8173_nor->base + MTK_NOR_CFG2_REG); return readb_poll_timeout(mt8173_nor->base + MTK_NOR_CFG2_REG, reg, - 0x01 == (reg & 0x01), 100, 10000); + (reg & 0x01) == 0x01, 100, 10000); } static int mt8173_nor_write_buffer_disable(struct mt8173_nor *mt8173_nor) @@ -220,7 +220,7 @@ static int mt8173_nor_write_buffer_disab writel(MTK_NOR_WR_BUF_DISABLE, mt8173_nor->base + MTK_NOR_CFG2_REG); return readb_poll_timeout(mt8173_nor->base + MTK_NOR_CFG2_REG, reg, - MTK_NOR_WR_BUF_DISABLE == (reg & 0x1), 100, + (reg & 0x1) == MTK_NOR_WR_BUF_DISABLE, 100, 10000); } -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
