Hey Thierry,
but why have the bit macro at all then :)
But that choice I guess I leave to you, as it's your section, I know
some submaintainers prefer it and want it to be used, so I guess it's
something in general kernel wide that should be desided on, BIT() macro
preferred or not.
Olliver
On 06-11-15 15:46, Thierry Reding wrote:
On Mon, Oct 26, 2015 at 10:32:35PM +0100, Olliver Schinagl wrote:
From: Olliver Schinagl <oliver@xxxxxxxxxxx>
The pwm header defines bits manually while there is a nice bitops.h with
a BIT() macro. Use the BIT() macro to set bits in pwm.h
Signed-off-by: Olliver Schinagl <oliver@xxxxxxxxxxx>
---
include/linux/pwm.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
I don't think this is a useful change. The BIT() macro needs the same
number of characters to type at the expense of requiring an additional
include.
Thierry
--
Met vriendelijke groeten, Kind regards, 与亲切的问候
Olliver Schinagl
Software Engineer
Research & Development
Ultimaker B.V.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
