Re: [PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage regulator driver

[kbuild test robot <lkp@xxxxxxxxx>]

Hi Chen,

[auto build test ERROR on regulator/for-next]
[also build test ERROR on v4.3 next-20151106]

url:    https://github.com/0day-ci/linux/commits/Chen-Feng/Add-Support-for-Hi6220-PMIC-Hi6553-MFD-Core/20151105-215603
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
config: arm-allmodconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All error/warnings (new ones prefixed by >>):

   drivers/regulator/hi6220-mtcmos.c: In function 'hi6220_mtcmos_enable':
>> drivers/regulator/hi6220-mtcmos.c:105:2: error: expected ';' before 'return'
     return ret;
     ^
>> drivers/regulator/hi6220-mtcmos.c:106:1: warning: no return statement in function returning non-void [-Wreturn-type]
    }
    ^
--
   drivers/regulator/hi655x-regulator.c: In function 'hi655x_disable':
>> drivers/regulator/hi655x-regulator.c:65:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
     ^
   drivers/regulator/hi655x-regulator.c: In function 'hi655x_get_voltage':
   drivers/regulator/hi655x-regulator.c:81:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     struct hi655x_regulator_vset_regs *vset_regs = &regulator->vset_regs;
     ^
   drivers/regulator/hi655x-regulator.c: In function 'hi655x_set_voltage':
   drivers/regulator/hi655x-regulator.c:101:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     struct hi655x_regulator_vset_regs *vset_regs = &regulator->vset_regs;
     ^
   drivers/regulator/hi655x-regulator.c: In function 'hi655x_regulator_probe':
   drivers/regulator/hi655x-regulator.c:189:6: warning: unused variable 'ret' [-Wunused-variable]
     int ret = 0;
         ^

vim +65 drivers/regulator/hi655x-regulator.c

    49		struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
    50	
    51		ret = regmap_update_bits(rdev->regmap, ctrl_regs->enable_reg,
    52					 regulator->ctrl_mask, regulator->ctrl_mask);
    53		return ret;
    54	}
    55	
    56	static int hi655x_disable(struct regulator_dev *rdev)
    57	{
    58		int ret = 0;
    59		struct hi655x_regulator *regulator = rdev_get_drvdata(rdev);
    60	
    61		if (!regulator) {
    62			pr_err("get driver data error!\n");
    63			return -ENODEV;
    64		}
  > 65		struct hi655x_regulator_ctrl_regs *ctrl_regs = &regulator->ctrl_regs;
    66	
    67		ret = regmap_update_bits(rdev->regmap, ctrl_regs->disable_reg,
    68					 regulator->ctrl_mask, regulator->ctrl_mask);
    69		return ret;
    70	}
    71	
    72	static int hi655x_get_voltage(struct regulator_dev *rdev)
    73	{

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data