On 05-11-15, 17:33, Rob Herring wrote: > On Wed, Nov 4, 2015 at 9:19 PM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: > > On 04-11-15, 21:02, Rob Herring wrote: > >> > +- turbo-mode-<name>: Named turbo-mode property. Similar to opp-microvolt-<name> > >> > + property, but for turbo mode instead. > >> > + > >> > - opp-suspend: Marks the OPP to be used during device suspend. Only one OPP in > >> > the table should have this. > >> > > >> > +- opp-suspend-<name>: Named opp-suspend property. Similar to > >> > + opp-microvolt-<name> property, but for suspend opp instead. > >> > + > >> > >> I don't think these last 2 make sense. turbo-mode is a flag that the > >> mode has restrictions such as other cores have to be idle or something. > >> Similarly, opp-suspend should not vary by <name>. > > > > Based on what version of the hardware you are running, via > > opp-supported-hw property, the platform can enable a different set of > > OPPs. And in that case we may want to select different OPPs marked as > > turbo or suspend freq. That's what I thought at least. > > > > For example, on version A of the hardware we have following available > > frequencies: 800, 1000, 1100, 1200 MHz. Where 800 MHz is the suspend > > freq and 1200 is the turbo one. > > > > But on a slightly different version of hardware B, we have two more > > OPPs available: 700 and 1400 MHz. And in that case we want the suspend > > freq to be 700 and turbo OPP to be only 1400 MHz. > > But different frequencies are different OPP nodes (since that is the > unit address now), so it is not going to hurt to set turbo-mode on > both 1200 and 1400. Yeah, but in that case 1200 *may* not be a turbo frequency anymore, as the voltage constraints might have changed. So turbo frequency is something that should be used only in small bursts, as they are consume lot of power. They aren't available to be used freely. They may also have thermal side effects.. In a similar way, for suspend-freq, we may or may not want the lowest frequency to be used during suspend and so that can change as well. And we shouldn't have suspend-freq set for two OPP nodes. -- viresh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
