Hi Milo, Thanks for the patch. Apart from the issues pointed out by Rob, I have one more suggestion below. On 11/02/2015 06:24 AM, Milo Kim wrote:
LM3633 LED device is one of TI LMU device list. Cc: devicetree@xxxxxxxxxxxxxxx Cc: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx> Cc: Lee Jones <lee.jones@xxxxxxxxxx> Cc: linux-kernel@xxxxxxxxxxxxxxx Cc: linux-leds@xxxxxxxxxxxxxxx Signed-off-by: Milo Kim <milo.kim@xxxxxx> --- .../devicetree/bindings/leds/leds-lm3633.txt | 28 ++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3633.txt diff --git a/Documentation/devicetree/bindings/leds/leds-lm3633.txt b/Documentation/devicetree/bindings/leds/leds-lm3633.txt new file mode 100644 index 0000000..bb7f213 --- /dev/null +++ b/Documentation/devicetree/bindings/leds/leds-lm3633.txt @@ -0,0 +1,28 @@ +TI LMU LM3633 LED device tree bindings + +Required properties: + - compatible: "ti,lm3633-leds" + +Child nodes: + Each node matches with LED control bank. + Please refer to the datasheet [1]. + + Required properties of a child node: + - lvled1-used, lvled2-used, lvled3-used, + lvled4-used, lvled5-used, lvled6-used: + Low voltage LED string configuration. Type is <boolean>. + Please describe which output LED string is used. + + Optional properties of a child node: + - channel-name: Name string for LED channel identification + It is used for creating LED sysfs, + /sys/class/leds/<channel-name>/. + If this property is empty, then default name is set to + "indicator:<id>" by the driver. + - led-max-microamp: Max current setting. Type is <u32>. + Unit is microampere. Range is from 5000 to 30000.
Could you specify also a step?
+Examples: Please refer to ti-lmu dt-bindings [2]. + +[1] http://www.ti.com/product/LM3633/datasheet +[2] Documentation/devicetree/bindings/mfd/ti-lmu.txt
-- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
