Joachim,
El 24/10/15 a las 18:44, Joachim Eastwood escribió:
> Hi Ariel,
>
> On 19 October 2015 at 19:32, Ariel D'Alessandro
> <ariel@xxxxxxxxxxxxxxxxxxxx> wrote:
>> Add the devicetree binding document for NXP LPC18xx EEPROM memory.
>>
>> Signed-off-by: Ariel D'Alessandro <ariel@xxxxxxxxxxxxxxxxxxxx>
>> ---
>> .../devicetree/bindings/nvmem/lpc1857-eeprom.txt | 26 ++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/nvmem/lpc1857-eeprom.txt
>>
>> diff --git a/Documentation/devicetree/bindings/nvmem/lpc1857-eeprom.txt b/Documentation/devicetree/bindings/nvmem/lpc1857-eeprom.txt
>> new file mode 100644
>> index 0000000..01cde0d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/nvmem/lpc1857-eeprom.txt
>> @@ -0,0 +1,26 @@
>> +* NXP LPC18xx EEPROM memory NVMEM driver
>> +
>> +Required properties:
>> + - compatible: Should be "nxp,lpc1857-eeprom"
>> + - reg: Must contain an entry with the physical base address and length
>> + for each entry in reg-names.
>> + - reg-names: Must include the following entries.
>> + - reg: EEPROM registers.
>> + - mem: EEPROM address space.
>> + - clocks: Must contain an entry for each entry in clock-names.
>> + - clock-names: Must include the following entries.
>> + - eeprom: EEPROM operating clock.
>> + - interrupts: Should contain EEPROM interrupt.
>
> You should document the 'reset' property as well.
Ok. Will do.
>
>> +Example:
>> +
>> + eeprom: eeprom@4000e000 {
>> + compatible = "nxp,lpc1857-eeprom";
>> + reg = <0x4000e000 0x1000>,
>> + <0x20040000 0x4000>;
>> + reg-names = "reg", "mem";
>> + clocks = <&ccu1 CLK_CPU_EEPROM>;
>> + clock-names = "eeprom";
>> + resets = <&rgu 27>;
>> + interrupts = <4>;
>> + };
>
> Other than that this looks good to me.
>
> Acked-by: Joachim Eastwood <manabian@xxxxxxxxx>
>
Great, thanks.
--
Ariel D'Alessandro, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
