On Tue, Oct 27, 2015 at 07:05:01PM -0700, Guenter Roeck wrote: > In general, naming a driver for the first chip it supports is not > problematic. Making it too generic is, on the other side, problematic. > What are you going to do if ts4900 (or ts4801) implements a different > watchdog ? Okay, I will keep the current name. I noticed that other boards might have their feed register at different offsets from syscon base. For instance, feed register is at offset 0x6 on TS-4720 and offset 0xE on TS-4800 (syscon registers are 16-bit wide). So I need to address that as well (it is related to the next point). Currently, the driver maps all syscon registers even if it uses only one of them. I was thinking about adding a "syscon" node and define the watchdog as a child of it, but the syscon driver set syscon_regmap_config.val_bits to 32. Do I have to create a new driver if I want to use val_bits = 16, or is there another way ? Damien -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
