On Wed, 28 Oct 2015, Steffen Trumtrar wrote:
> > +int fpga_bridge_enable(struct fpga_bridge *bridge)
> > +{
> > + pr_err("%s %s\n", __func__, dev_name(&bridge->dev));
>
> Please clean this...
>
> > +
> > + return bridge->br_ops->enable_set(bridge, 1);
> > +}
> > +EXPORT_SYMBOL_GPL(fpga_bridge_enable);
> > +
> > +/**
> > + * fpga_bridge_disable
> > + * @bridge: fpga bridge
> > + *
> > + * Disable transactions on the bridge
> > + *
> > + * Return: 0 for success, error code otherwise.
> > + */
> > +int fpga_bridge_disable(struct fpga_bridge *bridge)
> > +{
> > + pr_err("%s %s\n", __func__, dev_name(&bridge->dev));
>
> and this up.
>
OK
> > +void fpga_bridge_unregister(struct device *dev)
> > +{
> > + struct fpga_bridge *bridge = dev_get_drvdata(dev);
> > +
> > + dev_info(&bridge->dev, "%s : %s\n", __func__, bridge->name);
>
> Is this necessary information?
I can remove it.
> > +static int __init fpga_bridge_dev_init(void)
> > +{
> > + pr_info("FPGA bridge framework driver\n");
>
> Dito.
> IMHO unnecessary log spam. Maybe change this to dbg?
Sure.
> > --- /dev/null
> > +++ b/include/linux/fpga/fpga-bridge.h
> > @@ -0,0 +1,49 @@
> > +#include <linux/cdev.h>
>
> You don't seem to use this.
Correct. I'll take it out.
Thanks for the review!
Alan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
