Hi Linus, > -----Original Message----- > From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx] > Sent: 27 October 2015 15:11 > To: Pramod Kumar > Cc: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Ray Jui; > Scott Branden; Russell King; linux-gpio@xxxxxxxxxxxxxxx; bcm-kernel-feedback- > list; Jason Uy; Masahiro Yamada; Thomas Gleixner; Laurent Pinchart; > devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Jonas Gorski > Subject: Re: [PATCH 05/11] dt-binding: Add ngpios property to GPIO controller > node > > On Mon, Oct 19, 2015 at 7:43 AM, Pramod Kumar <pramodku@xxxxxxxxxxxx> > wrote: > > > Add ngpios property to the gpio controller's DT node so that > > controller driver extracts total number of gpio lines present in > > controller from DT and removes dependency on driver. > > > > Signed-off-by: Pramod Kumar <pramodku@xxxxxxxxxxxx> > > Reviewed-by: Ray Jui <rjui@xxxxxxxxxxxx> > > Reviewed-by: Scott Branden <sbranden@xxxxxxxxxxxx> > (...) > > +- ngpios: > > + Total number of GPIOs the controller provides > > This description is wrong. The number of GPIOs the controller *provides* is to > be determined by the compatible-string. > > ngpios is used to restrict the number of lines *used* or *routed* from the > number *available*. (I hope that is what the code does as well.) Such as if 12 > GPIOs are used of the 32 available on 32bits in a register. > > Update this description to say what it really means. > > Yours, > Linus Walleij Thanks for reviewing . Will update the description. Regards, Pramod ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
