Hello Mark,
Am 27.10.2015 um 03:12 schrieb Mark Brown:
On Mon, Oct 26, 2015 at 12:25:17PM +0100, Heiko Schocher wrote:
add DT support for the tps6502x regulators.
Please use subject lines matching the style for the subsystem.
Would be "regulator: tps6520x:" correct?
+ regulators = of_get_child_by_name(np, "regulators");
+ if (!regulators) {
+ dev_err(dev, "regulator node not found\n");
+ return NULL;
+ }
Please use the generic support for locating the DT information for
regulators using regulators_node and of_match in the regulator_desc
rather than open coding this.
Hmm.. could you point me to a correct example? Seems I overlook sth.
drivers/regulator/tps65090-regulator.c
drivers/regulator/tps65910-regulator.c
drivers/regulator/tps6507x-regulator.c
drivers/regulator/tps6586x-regulator.c
are doing it all the same way ...
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
