On Sun, Oct 11, 2015 at 01:04:12PM -0700, Brian Norris wrote: > On Tue, Aug 18, 2015 at 03:34:08PM -0000, Michal Suchanek wrote: > > The lock flag of ofpart is undocumented. Add to binding doc. > > Good catch. There are a lot of small corners of very old code that never > really got reviewed properly, I expect... > > (And the flag looks very odd. Why exactly is it in the partitions?) > > And now that I'm looking further...does this flag even *do* anything? > AFAICT, it doesn't set the master device flags -- only the partition > flags. But MTD drivers currently never see the partition flags -- they > only see the master struct mtd_info. I think the only way anyone could > observe the effect of this flag is to read the MTD flags from sysfs. And > that's pretty useless. > > If my understanding is correct, then I'd rather completely remove the > code that "handles" this flag, rather than codify it in the docs. I've tested and confirmed: this only sets the flags for the partition (*NOT* for the master device), so the only visible effect of this property is to change sysfs flags. I'll send out a patch to kill this property entirely. Brian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
