On Sat, 26 Oct 2013 01:40:31 +0200, Sebastian Reichel <sre@xxxxxxxxxx> wrote:
> On Fri, Oct 25, 2013 at 08:09:04PM +0100, Grant Likely wrote:
> > On Thu, 24 Oct 2013 16:48:44 +0200, Sebastian Reichel <sre@xxxxxxxxxx> wrote:
> > > Add device tree support for twl4030 power button driver.
> >
> > The above commit text is insufficient. There are changes in the patch
> > that aren't described here and have nothing to do with device tree
> > bindings.
>
> I will update the description in PATCHv7.
>
> > [...]
> > > +++ b/Documentation/devicetree/bindings/input/twl4030-pwrbutton.txt
> >
> > Can all of the TWL or TWL4030 funciton bindings be collected into a
> > single file please? It is a single device after all. All of it should be
> > in bindings/mfd/twl-family.txt
>
> I guess this should be done in another patch? There's also a typo in
> twl-family.txt's filename. My suggestion is to leave the patchset in
> its current state. I will create another patch, which combines all
> the twl4030 bindings descriptions into one file.
Yes, that is fine.
>
> > [...]
> > > +- interrupt: should be one of the following
> >
> > Spelling: s/interrupt/interrupts/
>
> fixed.
>
> > [...]
> > > static struct platform_driver twl4030_pwrbutton_driver = {
> > > + .probe = twl4030_pwrbutton_probe,
> > > .remove = __exit_p(twl4030_pwrbutton_remove),
> >
> > Remove the __exit_p() wrapper. __exit is for module exit functions, not
> > remove hooks (I know, that's not actually this patch, but the code is
> > definitely wrong here).
>
> On of the following patches converts the driver to devm, which
> results in complete removal of the twl4030_pwrbutton_remove
> function.
Okay.
g.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
