Hi Grant, On Fri, Oct 25, 2013 at 08:10:28PM +0100, Grant Likely wrote: > > + - cover-comp-gain : integer used as multiplier for gain > > + compensation (default = 1) > > Should be taos,cover-comp-gain Has been updated to "amstaos,cover-comp-gain" in the latest patches, see https://lkml.org/lkml/2013/10/25/59 > Otherwise looks fine to me. Is this an acked-by? > > + else if (np) > > + of_property_read_u32_index(np, "cover-comp-gain", 0, > > + &chip->cover_comp_gain); > > of_property_read_u32() should be sufficient. You don't need the _index > variant. ah, I missed the function when skipping over linux/of.h. I will sent another update. -- Sebastian
Attachment:
signature.asc
Description: Digital signature
