Re: [PATCH] of: introduce of_get_available_child_count

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, Sep 24, 2013 at 2:22 PM, Bryan Wu <cooloney@xxxxxxxxx> wrote:
> On Tue, Sep 24, 2013 at 2:16 PM, Rob Herring <robherring2@xxxxxxxxx> wrote:
>> On 09/24/2013 12:50 PM, Bryan Wu wrote:
>>> Some drivers keep counting available child by themselves. So
>>> introduce a new simple API like of_get_child_count() but for
>>> available childs.
>>>
>>> Cc: Josh Wu <josh.wu@xxxxxxxxx>
>>> Signed-off-by: Bryan Wu <cooloney@xxxxxxxxx>
>>> ---
>>
>> Acked-by: Rob Herring <rob.herring@xxxxxxxxxxx>
>>

Will this patch be merged through you guys or need I take care of it?

Thanks,
-Bryan

>> I assume you have some user and will take this dependency thru that tree?
>>
>
> Exactly, a patch from Josh [1] inspired me to create this API.
>
> Thanks,
> -Bryan
>
> [1]: https://lkml.org/lkml/2013/9/24/68
>
>
>>>  include/linux/of.h | 16 ++++++++++++++++
>>>  1 file changed, 16 insertions(+)
>>>
>>> diff --git a/include/linux/of.h b/include/linux/of.h
>>> index f95aee3..54c2560 100644
>>> --- a/include/linux/of.h
>>> +++ b/include/linux/of.h
>>> @@ -226,6 +226,17 @@ static inline int of_get_child_count(const struct device_node *np)
>>>       return num;
>>>  }
>>>
>>> +static inline int of_get_available_child_count(const struct device_node *np)
>>> +{
>>> +     struct device_node *child;
>>> +     int num = 0;
>>> +
>>> +     for_each_available_child_of_node(np, child)
>>> +             num++;
>>> +
>>> +     return num;
>>> +}
>>> +
>>>  extern struct device_node *of_find_node_with_property(
>>>       struct device_node *from, const char *prop_name);
>>>  #define for_each_node_with_property(dn, prop_name) \
>>> @@ -376,6 +387,11 @@ static inline int of_get_child_count(const struct device_node *np)
>>>       return 0;
>>>  }
>>>
>>> +static inline int of_get_available_child_count(const struct device_node *np)
>>> +{
>>> +     return 0;
>>> +}
>>> +
>>>  static inline int of_device_is_compatible(const struct device_node *device,
>>>                                         const char *name)
>>>  {
>>>
>>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux