On Thu, Oct 24, 2013 at 09:34:59AM +0100, Grant Likely wrote: > On Wed, 23 Oct 2013 18:20:02 +0100, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: > > > > > Do we really want to polute the drivers and DT files with a ! in the > > > compatible values? I thought we'd considered that, but chosen having the > > > drivers that use unstable bindings depend on a Kconfig option as an > > > alternative, not an additional step? > > > > I'd even go further and use "unstable-" as the prefix instead of "!" > > which is way more explicit. > > > > > > > The one issue with doing this is that if a binding is thought to be > > > unstable, but becomes stable later without any changes, we'll have to do > > > busy-work to remove the ! in all the DT files, thus artificially > > > introducing an incompatibility. Perhaps that's fine though? > > > > I'd say yes. Going from unstable to stable is quite a step for a binding > > and that should be visible and worth a patch IMO. Also, when looking at > > a DTS file or some driver code, it will avoid > > confusion/misinterpretation if one can see immediately the status of a > > binding. > > No, it shouldn't. Going from unstable to stable is not a large step, > rather it is coming to the point of looking around and realizing that > the binding is working quite well. Yes, the difference between the unstable binding before it is declared stable and the stable one shouldn't be big. In fact it should be no different at all. However the decision is still a conscious one. And it is a big step, because when you declare it stable you assert that it will never change in an incompatible way. > I don't think the solution is to put this into the kernel to be checked > at runtime. The better solution is to put it into DTC and make it > complain (either warn or error; depending on build config?) about usage > of compatible strings that are marked in the binding documentation as > unstable. Perhaps. Doing it in the kernel seemed easier. Furthermore not every user might generate their own DTB and whoever generates the DTB may not make the same choice as every user might have made. Granted, that might be a little far fetched. I personally don't mind where exactly it is checked for, as long as we can settle on something. What I'm primarily concerned about is that the current situation hinders progress and early adoption, which I consider both essential for upstream Linux development. Thierry
Attachment:
pgpaI7LWYRzmG.pgp
Description: PGP signature
