Gupta, I already have a question :-) On Sat, Oct 19, 2013 at 02:14:14PM +0530, Pekon Gupta wrote: > With OMAP NAND driver updates, selection of ecc-scheme: > *DT enabled kernel* > depends on ti,nand-ecc-opt and ti,elm-id DT bindings. > *Non DT enabled kernel* > depends on elm_dev and ecc-scheme passed along with platform-data > from board file. > > So, selection of ecc-scheme (BCH8 or BCH4) from KConfig can be removed > > Signed-off-by: Pekon Gupta <pekon@xxxxxx> > --- > drivers/mtd/nand/Kconfig | 40 ++++++---------------------------------- > 1 file changed, 6 insertions(+), 34 deletions(-) > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > index d885298..93ae6a6 100644 > --- a/drivers/mtd/nand/Kconfig > +++ b/drivers/mtd/nand/Kconfig > @@ -96,43 +96,15 @@ config MTD_NAND_OMAP2 > > config MTD_NAND_OMAP_BCH > depends on MTD_NAND && MTD_NAND_OMAP2 && ARCH_OMAP3 I'm wondering how are you testing this in your SOC_AM33XX board (which is not ARCH_OMAP3). You probably have ARCH_OMAP3 always selected? IMO, no need to depend on any ARCH_xxx, just make it depend on the driver option itself, which already depends on ARCH_OMAP2PLUS (which is the bigger SoC family). Care to send a one-patch fix for that, so this *independent* bug can be taken by Brian? Please add my Reported-by when you do so. -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
