On Tue, Oct 22, 2013 at 03:38:47PM +0100, dinguyen@xxxxxxxxxx wrote:
> From: Dinh Nguyen <dinguyen@xxxxxxxxxx>
>
> Add device tree support to the DW watchdog timer.
>
> Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> Acked-by: Jamie Iles <jamie@xxxxxxxxxxxxx>
> Reviewed-by: Pavel Machek <pavel@xxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: Jamie Iles <jamie@xxxxxxxxxxxxx>
> Cc: Viresh Kumar <viresh.linux@xxxxxxxxx>
> Cc: Wim Van Sebroeck <wim@xxxxxxxxx>
> Cc: Pavel Machek <pavel@xxxxxxx>
> Cc: Rob Herring <rob.herring@xxxxxxxxxxx>
> Cc: Pawel Moll <pawel.moll@xxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Stephen Warren <swarren@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Cc: linux-watchdog@xxxxxxxxxxxxxxx
> ---
> v5:
> - Add documentation for clocks property
> v4:
> - Add interrupts as an optional property, use "should contain".
> v3:
> - Clean up documentation
> v2:
> - Use of_match_ptr() for of_match_table
> ---
> .../devicetree/bindings/watchdog/dw_wdt.txt | 20 ++++++++++++++++++++
> drivers/watchdog/dw_wdt.c | 8 ++++++++
> 2 files changed, 28 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/watchdog/dw_wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/dw_wdt.txt b/Documentation/devicetree/bindings/watchdog/dw_wdt.txt
> new file mode 100644
> index 0000000..3af5c13
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/dw_wdt.txt
> @@ -0,0 +1,20 @@
> +Synopsys Designware Watchdog Timer
> +
> +Required Properties:
> +
> +- compatible : Should contain "snps,dw-wdt"
> +- reg : Base address and size of the watchdog timer register.
s/register/registers/ ?
> +- clocks : phandle to the clock that drives the watchdog timer.
Nit: clocks aren't necessarily described by just a phandle.
How about:
- clocks: phandle + clock-specifier for the clock that drives the watchdog
timer.
Otherwise, given previous comments this looks fine to me.
Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
