On Tue, Oct 08, 2013 at 10:00:15AM +0100, Russell King - ARM Linux wrote:
> On Tue, Oct 08, 2013 at 11:40:51AM +0800, Shawn Guo wrote:
> > On Mon, Oct 07, 2013 at 08:52:40PM -0600, Stephen Warren wrote:
> > > >>> &usdhc1 {
> > > >>> pinctrl-names = "default";
> > > >>> pinctrl-0 = <&pinctrl_usdhc1_1 &pinctrl_usdhc1_1_dat3cd>;
> > > >>> ...
> > > >>> status = "okay";
> > > >>> };
> > > >>
> > > >> Are you sure that this will always be the case? This would assume that
> > > >> the pinctrl entries are always processed sequentially.
> > > >
> > > > That will always be the case per my understanding. Otherwise, I would
> > > > be so surprised. Are you seeing any case that the entries are not
> > > > processed sequentially?
> > >
> > > Given the way the Linux code currently works, I think that will
> > > currently happen in practice. However, there's nothing in the pinctrl DT
> > > binding documentation that guarantees (or even mentions) such semantics.
> >
> > Ah, that's Russell's point, I guess. I think it makes perfect sense to
> > make this clear in the binding doc, as this "overwrite mechanism" can be
> > very helpful. I will send a patch for it.
>
> Exactly - otherwise we're just relying on implementation details.
> There's nothing at present which mandates starting at the first entry
> and working through sequentially to the last entry, which means another
> implementation can choose to operate in the opposite order. If it does,
> what you're suggesting won't work so well.
>
> However, there's another point to consider. In cases like this, we will
> cause a glitch on the pin. When we process the initial set, we will set
> the pull-up high, and then later set it low. That may not be a problem
> in this case, but that's not to say it won't be in every case, and that's
> something which also needs to be considered.
I can't find what the result of this discussion was, but from what I
remember, we decided that we weren't going to do this override thing,
and instead we were going to separate out the configuration of DAT3.
Who's going to do that? I'd rather not, because it means editing
quite a number of DT files which I have no way to test, and the
chances of messing this up are quite high. I've already developed
a deep seated hatred for DT in general through my involvement with
IMX, particularly how it's very easy to make an undetected mistake
and then spend hours debugging it.
Until this is resolved, I'm sticking with my own method of redefining
the entire pinctrl set for DAT3 pull-down, which I've tested as working.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
