I'll let the DT guys do the deep review. Just a couple of small points from me though. 1. MFD patches have the following syntax: mfd: <device>[-sub]: <Description> /* Note the uppercase 'D' */ > This defines the device tree bindings for the Toshiba TC3589x > series of multi-purpose expanders. Only the stuff I can test > is defined: GPIO and keypad. Others may implement more > subdevices further down the road. > > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/mfd/tc3589x.txt | 61 +++++++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/tc3589x.txt 2. The binding document is normally attached to the patch which applies the bindings, unless we've stopped doing that now. > + > +Example: > + 3. You left off the example? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
