Re: [PATCH v2 3/3] ARM: bcm281xx: Add thermal driver to device tree.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/13/2013 3:19 PM, Eduardo Valentin wrote:
On 27-09-2013 18:37, Wendy Ng wrote:
This patch adds the device tree node for Broadcom bcm281xx SoCs thermal
driver.

Signed-off-by: Wendy Ng <wendy.ng@xxxxxxxxxxxx>
Reviewed-by: Markus Mayer <mmayer@xxxxxxxxxxxx>
Reviewed-by: Christian Daudt <csd@xxxxxxxxxxxx>
---
  arch/arm/boot/dts/bcm11351-brt.dts |    4 +++-
  arch/arm/boot/dts/bcm11351.dtsi    |    6 ++++++
  arch/arm/boot/dts/bcm28155-ap.dts  |    4 ++++
  3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/bcm11351-brt.dts b/arch/arm/boot/dts/bcm11351-brt.dts
index 9d36eb4..0771b6b 100644
--- a/arch/arm/boot/dts/bcm11351-brt.dts
+++ b/arch/arm/boot/dts/bcm11351-brt.dts
@@ -43,5 +43,7 @@
  		status = "okay";
  	};

-
+	thermal@34008000 {
+		status = "okay";
+	};
  };
diff --git a/arch/arm/boot/dts/bcm11351.dtsi b/arch/arm/boot/dts/bcm11351.dtsi
index 05a5aab..aa13353 100644
--- a/arch/arm/boot/dts/bcm11351.dtsi
+++ b/arch/arm/boot/dts/bcm11351.dtsi
@@ -96,4 +96,10 @@
  		status = "disabled";
  	};

+	thermal@34008000 {
+		compatible = "brcm,bcm11351-thermal", "brcm,kona-thermal";
+		reg = <0x34008000 0x0024>;
+		thermal-name = "bcm_kona_therm";

As I mentioned previously, my only concern is this thermal binding,
which is specific to your driver (BTW, you would need to do
bcm,thermal-name)


Hi Eduardo,

I have a local working copy of the thermal driver that does not use the 'thermal-name' from this DTS file. It has been re-based to your working version of the new thermal DT binding.

+		status = "disabled";
+	};
  };
diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
index 96ae67a..a39aa47 100644
--- a/arch/arm/boot/dts/bcm28155-ap.dts
+++ b/arch/arm/boot/dts/bcm28155-ap.dts
@@ -42,4 +42,8 @@
  		max-frequency = <48000000>;
  		status = "okay";
  	};
+
+	thermal@34008000 {
+		status = "okay";
+	};
  };





--
Best regards,
-Wendy

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux