On Tuesday 15 October 2013, Haojian Zhuang wrote:
> Enable Hisilicon Hi4511 development platform with device tree support.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@xxxxxxxxxx>
Based on my other mail, some more comments here:
> +/ {
> + clocks {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
Since all clocks are in the fc802000 page, I would prefer using a non-empty
ranges to map the clocks into their own address space, like
ranges = <0 0xfc802000 0x1000>;
> + timer4_mux: timer4_mux@fc802018 {
> + compatible = "hisilicon,clk-mux";
> + #clock-cells = <0>;
> + clocks = <&osc32k &timerclk45>;
> + clock-output-names = "timer4_mux";
> + reg = <0xfc802018 0x4>;
> + clkmux-mask = <0x3>;
> + clkmux-table = <0 0x1>;
> + };
which would turn this into
timer4_mux: timer4_mux@18 {
...
reg = <0x18 0x4>;
...
};
The code would not be impacted by this.
On a related note, I find it strange that you have multiple devices with the
same register. Normally, we try to have device node names be generic,
e.g. 'clock@18' rather than 'timer4_mux@18', but that won't work if the
register is the same for all of them. Maybe some DT expert can comment
on this.
> +
> + amba {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "arm,amba-bus";
> + interrupt-parent = <&gic>;
> + ranges;
> +
> + L2: l2-cache {
> + compatible = "arm,pl310-cache";
> + reg = <0xfc10000 0x100000>;
> + interrupts = <0 15 4>;
> + cache-unified;
> + cache-level = <2>;
> + };
For this node, we could use the same trick with the non-empty ranges, since
all amba devices seem to be in the 0xfc000000 range.
If you do that, it probably makes sense to move the clock controller under here
as well.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
