On Sat, Oct 12, 2013 at 3:54 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > Hi all, > > for_each_child_of_node() and similar functions increase the refcount > on each returned node and expect the caller to release the node by > calling of_node_put() when done. > > Looking through the kernel code, it appears this is hardly ever done, > if at all. Some code even calls of_node_get() on returned nodes again. > > I guess this doesn't matter in cases where devicetree is a static entity. > However, this is not (or no longer) the case with devicetree overlays, > or more generically in cases where devicetree nodes are added and > removed dynamically. > > Fundamental question: Would patches to fix this problem be accepted upstream > ? Certainly. > Or, of course, stepping a bit back: Am I missing something essential ? No. I think this is frequently wrong since it typically doesn't matter for static entries as you mention. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
