* Brian Norris <computersforpeace@xxxxxxxxx> [131011 11:23]: > Hi Pekon, > > On Fri, Oct 11, 2013 at 07:06:43PM +0530, Pekon Gupta wrote: > > "Managed Device Resource" or devm_xx calls takes care of automatic freeing > > of the resource in case of: > > - failure during driver probe > > - failure during resource allocation > > - detaching or unloading of driver module (rmmod) > > Reference: Documentation/driver-model/devres.txt > > > > Though OMAP NAND driver handles freeing of resource allocation in most of > > the cases, but using devm_xx provides more clean and effortless approach > > to handle all such cases. > > Judging by your patch, I think you missed the point of the devm_* > managed functions. They are useful because you don't need to do any of > the cleanup (kfree(), iounmap(), etc.) yourself. I'll note the changes > that are necessary below, but seeing as this is an add-on to your patch > series, I may merge the rest of series without this, and if so, you can > just resubmit this patch separately. FYI, the .dts changes should be queued separately by Benoit to avoid pointless merge conflicts. The arch/arm/mach-omap2/gpmc.c changes I need to look, hopefully I can ack those for you today so you can take the code related changes into the MTD tree. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
