Hi,
On Thursday 10 October 2013 03:38 PM, Mark Rutland wrote:
On Thu, Oct 10, 2013 at 07:36:33AM +0100, Archit Taneja wrote:
Add Dynamic Memory Manager (DMM) bindings for OMAP4 and OMAP5 devices. DMM
only requires address and irq information.
Add documentation for the DMM bindings.
Originally worked on by Andy Gross <andygro@xxxxxxxxx>
Cc: Andy Gross <andygro@xxxxxxxxx>
Signed-off-by: Archit Taneja <archit@xxxxxx>
---
Documentation/devicetree/bindings/arm/omap/dmm.txt | 16 ++++++++++++++++
arch/arm/boot/dts/omap4.dtsi | 7 +++++++
arch/arm/boot/dts/omap5.dtsi | 7 +++++++
3 files changed, 30 insertions(+)
create mode 100644 Documentation/devicetree/bindings/arm/omap/dmm.txt
diff --git a/Documentation/devicetree/bindings/arm/omap/dmm.txt b/Documentation/devicetree/bindings/arm/omap/dmm.txt
new file mode 100644
index 0000000..6fc3d79
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/omap/dmm.txt
@@ -0,0 +1,16 @@
+OMAP Dynamic Memory Manager (DMM) bindings
Is there any documentation? A brief description of what this is would be
nice.
I'll do that.
+
+Required properties:
+- compatible: Must be "ti,omap4-dmm" for OMAP4 family
+ Must be "ti,omap5-dmm" for OMAP5 and DRA7x family
s/must be/should contain/
+- reg: Contains timer register address range (base address and length)
Huh? What's a timer got to do with the DMM?
Err, my mistake!
+- interrupts: Contains interrupt information (source, etc) for the DMM IRQ
Is there a single interrupt? If so:
- interrupts: Should contain an interrupt-specifier for the DMM IRQ.
Okay.
Assuming the "DMM IRQ" is well defined. If there's a name for it in
documentation, using that's preferable. If a future revision may have
multiple interrupts, please use interrupt-names now to save us endless
pain in future.
The IRQ is called DMM_IRQ in the documentation. I don't think there
would be more than one interrupt line from this IP. I'll still cross check.
Thanks,
Archit
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html