Hi Leela, On 10 October 2013 11:12, Leela Krishna Amudala <l.krishna@xxxxxxxxxxx> wrote: > Add the device-tree binding for the PWM controller to Exynos5250 and Exynos5420 > > Signed-off-by: Andrew Bresticker <abrestic@xxxxxxxxxxxx> > Signed-off-by: Olof Johansson <olofj@xxxxxxxxxxxx> > Signed-off-by: Leela Krishna Amudala <l.krishna@xxxxxxxxxxx> > --- > arch/arm/boot/dts/exynos5250.dtsi | 9 +++++++++ > arch/arm/boot/dts/exynos5420.dtsi | 9 +++++++++ > 2 files changed, 18 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index 864ae90..99abc72 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -521,6 +521,15 @@ > }; > }; > > + pwm: pwm@12dd0000 { > + compatible = "samsung,exynos4210-pwm"; > + reg = <0x12dd0000 0x100>; > + samsung,pwm-outputs = <0>, <1>, <2>, <3>; > + #pwm-cells = <3>; > + clocks = <&clock 311>; > + clock-names = "timers"; > + }; > + > amba { > #address-cells = <1>; > #size-cells = <1>; > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > index d537cd7..80afc8b 100644 > --- a/arch/arm/boot/dts/exynos5420.dtsi > +++ b/arch/arm/boot/dts/exynos5420.dtsi > @@ -206,6 +206,15 @@ > clock-names = "uart", "clk_uart_baud0"; > }; > > + pwm: pwm@12dd0000 { > + compatible = "samsung,exynos4210-pwm"; > + reg = <0x12dd0000 0x100>; > + samsung,pwm-outputs = <0>, <1>, <2>, <3>; > + #pwm-cells = <3>; > + clocks = <&clock 279>; > + clock-names = "timers"; > + }; > + Looking at the properties in the above 2 nodes, can't we have the common ones defined in exynos5.dtsi? -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html