Hi Stephen,
On 10/04/2013 07:37 PM, Stephen Boyd wrote:
> On 10/04/13 09:31, Stanimir Varbanov wrote:
>>
>>>> +static int msm_rng_probe(struct platform_device *pdev)
>>>> +{
>>>> + struct msm_rng *rng;
>>>> + struct device_node *np;
>>>> + struct resource res;
>>>> + int ret;
>>>> +
>>>> + np = of_node_get(pdev->dev.of_node);
>>>> + if (!np)
>>>> + return -ENODEV;
>>> This is unnecessary.
>> I used this call because CONFIG_OF_DYNAMIC could be enabled at some
>> time. Isn't that possible? I saw that of_node_get|put is used in .probe
>> on few places in drivers.
>
> So far we aren't selecting that config on ARM.
>
> If you look at of_device_alloc() you'll see
>
> dev->dev.of_node = of_node_get(np);
>
> so any platform devices created from of_platform_populate won't have
> their of_node go away.
Thanks for the pointers, it makes sense. I'll remove the calls to
of_node_get|put.
regards,
Stan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
