Quoting Tero Kristo (2013-09-25 01:48:26) > + > +static const struct clk_ops apll_ck_ops = { > + .enable = &dra7_apll_enable, > + .disable = &dra7_apll_disable, Looks like .is_enabled is missing? Also have you thought about using .prepare or .unprepare for these PLLs which might take some time to lock? The code there doesn't sleep or schedule, but it does poll for some time while under a spinlock. Something to think about for a future patch. Regards, Mike -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html