On 09/26/2013 10:02 AM, Rhyland Klein wrote: > From: Darbha Sriharsha <dsriharsha@xxxxxxxxxx> > > Adds support for the bq24735 charger chipset. The bq24735 is a > high-efficiency, synchronous battery charger. > > It allows control of the charging current, input current, and the charger > voltage DAC's through SMBus. > diff --git a/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt b/Documentation/devicetree/bindings/power_supply/ti,bq24735.txt > +Optional properties : > + - ti,charge-current : Used to control and set the charging current. This value > + must be between 128mA and 8.128A with a 64mA step resolution. The POR value > + is 0x0000h. See spec for more details. > + - ti,charge-voltage : Used to control and set the charging voltage. This value > + must be between 1.024V and 19.2V with a 16mV step resolution. The POR value > + is 0x0000h. See spec for more details. > + - ti,input-current : Used to control and set the charger input current. This > + value must be between 128mA and 8.064A with a 128mA step resolution. The > + POR value is 0x1000h. See spec for more details. What units and representation do those properties use? I assume it's mA and mV, without any shift or register encoding, but the text doesn't make it clear. It'd be best to reference a specific register name rather than just saying "see the spec". -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html