Hi Yoshii-san, Thank you for the patch. On Tuesday 24 September 2013 13:12:06 takasi-y@xxxxxxxxxxxxx wrote: > Make sh clock framework core depend on HAVE_MACH_CLKDEV, and > set it > - y on sh for backward compatibility > - !CONFIG_COMMON_CLK on sh-mobile > This is a preparation for migration to common clock framework > from sh clock framework on sh-mobile. While I agree with this patch, I believe the use of the HAVE_MACH_CLKDEV configuration option to select whether to compile core.o in is a bit of an abuse. I would have created a new configuration option (SH_CLK_CORE in drivers/sh/Kconfig for instance) as 'def_bool y' that depends on SH || (ARM && !COMMON_CLK). However, as all ARCH_SHMOBILE platforms should be converted to the common clock framework, this is only temporary and could be revisited later, so I'm fine with keeping the patch as-is. > Signed-off-by: Takashi Yoshii <takashi.yoshii.zj@xxxxxxxxxxx> > --- > arch/arm/Kconfig | 2 +- > arch/sh/Kconfig | 1 + > drivers/sh/clk/Makefile | 3 +-- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 3f7714d..53044ca 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -650,7 +650,7 @@ config ARCH_SHMOBILE > select HAVE_ARM_SCU if SMP > select HAVE_ARM_TWD if SMP > select HAVE_CLK > - select HAVE_MACH_CLKDEV > + select HAVE_MACH_CLKDEV if !COMMON_CLK > select HAVE_SMP > select MIGHT_HAVE_CACHE_L2X0 > select MULTI_IRQ_HANDLER > diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig > index 224f4bc..f57e47f 100644 > --- a/arch/sh/Kconfig > +++ b/arch/sh/Kconfig > @@ -41,6 +41,7 @@ config SUPERH > select MODULES_USE_ELF_RELA > select OLD_SIGSUSPEND > select OLD_SIGACTION > + select HAVE_MACH_CLKDEV > help > The SuperH is a RISC processor targeted for use in embedded systems > and consumer electronics; it was also used in the Sega Dreamcast > diff --git a/drivers/sh/clk/Makefile b/drivers/sh/clk/Makefile > index 5d15ebf..e73b031 100644 > --- a/drivers/sh/clk/Makefile > +++ b/drivers/sh/clk/Makefile > @@ -1,3 +1,2 @@ > -obj-y := core.o > - > +obj-$(CONFIG_HAVE_MACH_CLKDEV) += core.o > obj-$(CONFIG_SH_CLK_CPG) += cpg.o -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
