Tomasz On Fri, Sep 27, 2013 at 4:25 AM, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote: >> >> Since we already have PMU "driver" in mach-exynos, which already has >> >> suspend/resume syscore ops, what about placing such configuration there >> >> instead? >> > >> > Any opinions on this? >> > >> >> In PMU we have control registers for other IPs (like USB, MIPI etc.,) >> also and I'm not sure where those registers are getting configured. >> If we want to configure WDT register in PMU driver then we have to >> consider configuring control regs for other IPs also and the DT node >> has to have all these control bit numbers. So instead of that I feel >> configuring it in WDT driver looks fine. > > I believe this depends on possible use cases, not the IP block itself. > If this is just a low level initial (and SoC specific) initialization > that doesn't require any co-operation with high level kernel/userspace > APIs, then I think there is no need to entangle the driver for watchdog > IP with SoC specific details outside the IP itself. > > [Adding more people on Cc for further discussion.] So isn't the register in the PMU there to save power in the case that the watchdog timer isn't being used? How is the PMU "driver" to know whether the watchdog is being used? Better IMHO that the watchdog driver knows to enable and disable itself as needed, right? -Doug -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
