On Mon, Sep 23, 2013 at 07:30:42PM +0100, Charles Keepax wrote: > Documentation/devicetree/bindings/mfd/arizona.txt | 26 +++++ > drivers/mfd/arizona-core.c | 116 +++++++++++++++++++++ It's probably more idomatic to put the parsing for these in the driver that uses them. > + - wlf,micd-ranges : Microphone detection level and key configuration, this > + field can be of variable length but should always be a multiple of 2 cells > + long, each two cell group represents one button configuration > + The first cell is the maximum impedance for this button in ohms > + The second cell the key that should be reported to the input layer This isn't good - the device tree is supposed to be an OS independant description of the hardware that can be used by any OS but this binding embeds Linux-specific numbers. There are a few Linux specific bindings where people have just given up due to the complexity of developing a generic description but this doesn't seem like it shuld be such a case. This is going to be used for buttons on headsets and essentially all real headsets can be covered by just defining the ability to set hook switch, fast forward and rewind.
Attachment:
signature.asc
Description: Digital signature
