> >>+++ b/Documentation/lp3943.txt > >>@@ -0,0 +1,62 @@ > >>+TI/National Semiconductor LP3943 MFD driver > >>+=========================================== <snip> > >Why do you need to document your driver in this way? > > > >If this stuff is really important (and most of it really isn't), then > >put it either in the commit log or in the driver. > > Unnecessary documentation makes it noisy, but I think the LP3943 > still needs the driver documentation for better understanding. > > Many people think LP3943 is just LED driver, but I really want to > share the application usages - PWM generators and GPIO expanders. > If the driver just supports LED functionality, then it would be > created as LED class driver. However, this patch-set enables more > generic driver usages. > So, this documentation would be helpful. > > And I want to keep the code and the documentation separate. > If the link address is changed, then only documentation file will be > modified, not source file. > > So, I'd like to create the fifth patch-set with new MFD > documentation subdirectory. > Additionally, LP3943 platform data example code will be added in the > 'Documentation/mfd/lp3943.txt'. It's for a platform which doesn't > support the device tree. So, I'd actually like to get Sam's opinion on this. NB: The documentation looks pretty rough at the moment. If we decide to accept the concept, it will have to be adapted quite a bit before full acceptance of the document will be granted. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
