> -----Original Message----- > From: Vinod Koul [mailto:vinod.koul@xxxxxxxxx] > Sent: Monday, September 23, 2013 12:26 PM > To: Lu Jingchang-B35083 > Cc: djbw@xxxxxx; shawn.guo@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 3/3] dma: Add Freescale eDMA engine driver support > > On Tue, Sep 17, 2013 at 08:08:46AM +0000, Lu Jingchang-B35083 wrote: > > > > + case DMA_PAUSE: > > > > + if (fsl_chan->edesc) > > > > + fsl_edma_disable_request(fsl_chan); > > > racy here too... > > It only set the channel HW register, no list is handled, > > is lock needed here? Thanks! > well thats the point while you are terminating the current trasnaction > can > complete and then start another one. You want to try and prevent these > case > also. Here you are neither locking the HW access nor the the list, so its > juts > waiting to crash! Thanks! I have sent out the new v6 patch last week with holding lock here, Could you please help review it? Best Regards, Jingchang ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
