Hi Tomasz, On Sat, Sep 14, 2013 at 5:16 AM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: > I don't like two things in this patch. > > First is that this looks completely like a configuration option, not > hardware description, so it's not something that should be put into DT. > Especially that users might want to use another wake-up trigger depending > on their use cases. I'd rather see this as a sysfs entry. > > Another thing is that this driver assumes that key events are indicated by > edges on the GPIO line, so I don't think level trigger setting make any > sense here. I'd rather allow three settings here (through a sysfs knob) - > key down, key up, key down or up. Thanks for your feedback. I agree with your suggestions. I will move this from platform data and DT to a sysfs property with three settings : rising, falling, both. -- Benson Leung Software Engineer, Chrom* OS bleung@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
