Hi Lee, On 09/18/2013 01:40 PM, Lee Jones wrote: > On Wed, 18 Sep 2013, Maxime COQUELIN wrote: > >> This patch supplies I2C configuration to B2000 and B2020 >> based on either STiH415 or STiH416 SoCs. >> >> Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxx> >> Signed-off-by: Maxime Coquelin <maxime.coquelin@xxxxxx> >> --- >> arch/arm/boot/dts/stih41x-b2000.dtsi | 7 +++++++ >> arch/arm/boot/dts/stih41x-b2020.dtsi | 20 ++++++++++++++++++++ >> 2 files changed, 27 insertions(+) >> >> diff --git a/arch/arm/boot/dts/stih41x-b2000.dtsi b/arch/arm/boot/dts/stih41x-b2000.dtsi >> index 8e694d2..346cc4bc 100644 >> --- a/arch/arm/boot/dts/stih41x-b2000.dtsi >> +++ b/arch/arm/boot/dts/stih41x-b2000.dtsi >> @@ -37,5 +37,12 @@ >> }; >> }; >> >> + /* HDMI Tx I2C */ >> + i2c1: i2c@fed41000{ > nit: Space before the '{' Ok. It will be fixed for all nodes in next series. > >> + status = "okay"; > Consider enabling the node at the bottom. > >> + >> + /* HDMI V1.3a supports Standard mode only */ >> + clock-frequency = <100000>; >> + }; >> }; >> }; >> diff --git a/arch/arm/boot/dts/stih41x-b2020.dtsi b/arch/arm/boot/dts/stih41x-b2020.dtsi >> index 133e181..10b98da 100644 >> --- a/arch/arm/boot/dts/stih41x-b2020.dtsi >> +++ b/arch/arm/boot/dts/stih41x-b2020.dtsi >> @@ -38,5 +38,25 @@ >> default-state = "off"; >> }; >> }; >> + >> + i2c0: i2c@fed40000{ > As above. > >> + status = "okay"; >> + }; >> + >> + /* HDMI Tx I2C */ >> + i2c1: i2c@fed41000{ > As above. > >> + status = "okay"; > As above. > >> + /* HDMI V1.3a supports Standard mode only */ >> + clock-frequency = <100000>; >> + }; >> + >> + sbc_i2c0: i2c@fe540000{ > As above. > >> + status = "okay"; >> + }; >> + >> + sbc_i2c1: i2c@fe541000{ > Are these nodes referenced by phandle at all? > > If not, consider dropping the <lable>:s It was references in an previous internal version of this series. This is no more the case, so I will drop the labels. > >> + status = "okay"; >> + }; >> }; >> }; > Odd tabbing here. > Thanks, Maxime -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html