Tomasz,
On Tue, Sep 17, 2013 at 6:30 AM, Tomasz Figa <t.figa@xxxxxxxxxxx> wrote:
>> --- a/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt
>> +++ b/Documentation/devicetree/bindings/watchdog/samsung-wdt.txt
>> @@ -7,8 +7,20 @@ occurred.
>> Required properties:
>> - compatible : should be "samsung,s3c2410-wdt"
>
> Since the WDT block of Exynos 5420 needs some extra configuration in PMU
> registers, it is no longer compatible with samsung.s3c2410-wdt. Please
> introduce separate compatible ("samsung,exynos5420-wdt") and make the
> driver handle the additional configuration only if running on a device with
> this compatible value.
>
> I'd suggest introducing quirk system to the driver and adding a
> NEEDS_PMU_CONFIG quirk selected by DT match entry with "samsung,exynos5420-
> wdt" compatible.
>
>> - reg : base physical address of the controller and length of memory
>> mapped - region.
>> + region and the optional (addresses and length of memory mapped regions
>> + of) PMU registers for masking/unmasking WDT.
>> - interrupts : interrupt number to the cpu.
>>
>> Optional properties:
>> - timeout-sec : contains the watchdog timeout in seconds.
>> +- reset-mask-bit: bit number in the PMU registers to program mask/unmask
>> WDT. +
>
> I believe this is mandatory on Exynos 5420 and unused on previous SoCs. It
> should be handled depending on compatible value.
I think at least 5250 needs something similar. I believe we got away
with it in the past since other (non-WDT) code was tweaking with this
bit, but that was a little bit gross. Leela Krishna can correct me if
I'm wrong.
-Doug
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
