On Sun, Sep 15, 2013 at 4:42 PM, Milo Kim <milo.kim@xxxxxx> wrote: > On 09/15/2013 07:50 PM, Linus Walleij wrote: >> >> This enables setting a default trigger on an LP55xx channel, >> either from platform data or device tree. This mechanism is >> identical to the mechanism for GPIO LEDs and references the >> common LEDs device tree bindings. >> >> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > > Acked-by: Milo Kim <milo.kim@xxxxxx> > Thanks, I merged it into my branch. -Bryan > >> --- >> Documentation/devicetree/bindings/leds/leds-lp55xx.txt | 10 +++++++--- >> drivers/leds/leds-lp55xx-common.c | 3 +++ >> include/linux/platform_data/leds-lp55xx.h | 1 + >> 3 files changed, 11 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.txt >> b/Documentation/devicetree/bindings/leds/leds-lp55xx.txt >> index a61727f..d221e75 100644 >> --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.txt >> +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.txt >> @@ -17,12 +17,15 @@ Optional properties: >> 2: D1~6 with VOUT, D7~9 with VDD >> 3: D1~9 are connected to VOUT >> >> -Alternatively, each child can have specific channel name >> -- chan-name: Name of each channel name >> +Alternatively, each child can have a specific channel name and trigger: >> +- chan-name (optional): name of channel >> +- linux,default-trigger (optional): see >> + Documentation/devicetree/bindings/leds/common.txt >> >> example 1) LP5521 >> 3 LED channels, external clock used. Channel names are >> 'lp5521_pri:channel0', >> -'lp5521_pri:channel1' and 'lp5521_pri:channel2' >> +'lp5521_pri:channel1' and 'lp5521_pri:channel2', with a heartbeat trigger >> +on channel 0. >> >> lp5521@32 { >> compatible = "national,lp5521"; >> @@ -33,6 +36,7 @@ lp5521@32 { >> chan0 { >> led-cur = /bits/ 8 <0x2f>; >> max-cur = /bits/ 8 <0x5f>; >> + linux,default-trigger = "heartbeat"; >> }; > > > And this DT example works well with 'ledtrig-heartbeat' module. > > Tested-by: Milo Kim <milo.kim@xxxxxx> > > Thanks. > > Best regards, > Milo -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html