Re: [PATCH v2 1/2] arm: dts: omap4+: Add DMM bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 16/09/13 12:30, Archit Taneja wrote:
> Add Dynamic Memory Manager (DMM) bindings for OMAP4 and OMAP5 devices. DMM
> only requires address and irq information.
> 
> Add documentation for the DMM bindings.
> 
> Originally worked on by Andy Gross.
> 
> Cc: Andy Gross <andygro@xxxxxxxxx>
> Signed-off-by: Archit Taneja <archit@xxxxxx>
> ---
>  Documentation/devicetree/bindings/arm/omap/dmm.txt | 17 +++++++++++++++++
>  arch/arm/boot/dts/omap4.dtsi                       |  7 +++++++
>  arch/arm/boot/dts/omap5.dtsi                       |  7 +++++++
>  3 files changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/omap/dmm.txt
> 
> diff --git a/Documentation/devicetree/bindings/arm/omap/dmm.txt b/Documentation/devicetree/bindings/arm/omap/dmm.txt
> new file mode 100644
> index 0000000..237cd83
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/omap/dmm.txt
> @@ -0,0 +1,17 @@
> +OMAP Dynamic Memory Manager (DMM) bindings
> +
> +Required properties:
> +- compatible:	Must be "ti,omap4-dmm" for OMAP4 family
> +		Must be "ti,omap5-dmm" for OMAP5 family
> +- reg:		Contains timer register address range (base address and length)

"timer"?

> +- interrupts:	Contains interrupt information (source, etc) for the DMM IRQ
> +- ti,hwmods:	Name of the hwmod associated to the counter, which is typically
> +		"dmm"

"associated to the counter"?

> +
> +Example:
> +
> +dmm: dmm@4e000000 {
> +	compatible = "ti,omap4-dmm";
> +	reg = <0x4e000000 0x800>;
> +	ti,hwmods = "dmm";
> +};
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index 22d9f2b..24f388e 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -487,6 +487,13 @@
>  			ti,hwmods = "kbd";
>  		};
>  
> +		dmm: dmm@4e000000 {

I don't think anyone refers to this node, so there shouldn't be any need
for the "dmm: " alias.

> +			compatible = "ti,omap4-dmm";
> +			reg = <0x4e000000 0x800>;
> +			interrupts = <0 113 0x4>;
> +			ti,hwmods = "dmm";
> +		};
> +
>  		emif1: emif@4c000000 {
>  			compatible = "ti,emif-4d";
>  			reg = <0x4c000000 0x100>;
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index ac1f1e0..33b4fea 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -604,6 +604,13 @@
>  			ti,hwmods = "wd_timer2";
>  		};
>  
> +		dmm: dmm@4e000000 {

Same here.

> +			compatible = "ti,omap5-dmm";
> +			reg = <0x4e000000 0x800>;
> +			interrupts = <0 113 0x4>;
> +			ti,hwmods = "dmm";
> +		};
> +
>  		emif1: emif@0x4c000000 {
>  			compatible	= "ti,emif-4d5";
>  			ti,hwmods	= "emif1";
> 


Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux