Re: [PATCH 1/4] arm: omap: display: Create omapdrm inside omap_display_init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Friday 13 September 2013 03:08 PM, Archit Taneja wrote:
On Friday 13 September 2013 02:54 PM, Tomi Valkeinen wrote:
On 13/09/13 12:14, Archit Taneja wrote:
Move omapdrm device creation inside the omap_display_init so that we can
correctly create the device based on the presence of omapdss.

Originally worked on by Andy Gross.

If the dmm device is present in the DT data, there is no need to create
the dmm device. It's created automatically.

Yes, that is done in a later patch.


Also, omapfb device is currently created the same way as omapdrm,
independently of omapdss. Why is it a problem to have them like that?

In a multiplatform config, we might have CONFIG_DRM_OMAP and
CONFIG_DRM_OMAP_MODULE selected.

I meant these configs might be selected even if the image is booted on am3xx platform.

Archit


This would cause the call omap_init_drm() in arch/arm/mach-omap2/drm.c
to occur. Creating a platform device for omapdrm is unnecessary here
isn't it? Tying it with the initialisation of omapdss devices prevents it.

Archit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux