On Thursday 12 of September 2013 09:03:23 Stephen Warren wrote:
> On 09/12/2013 06:58 AM, Tomasz Figa wrote:
> > Hi Mark,
> >
> > On Thursday 12 of September 2013 11:40:27 Mark Brown wrote:
> >> From: Mark Brown <broonie@xxxxxxxxxx>
> >>
> >> Ensure that unused I2C controllers are not activated, causing problems
> >> due to inappropriate pinmuxing or similar, by marking the controllers
> >> as
> >> disabled by default and requiring boards to explicitly enable those
> >> that
> >> are in use.
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts
> >>
> >> i2c@12C60000 {
> >>
> >> + status = "okay";
> >
> > I would keep the status properties at the end of all properties,
> > indicating that at this point the description is complete and also to
> > be consistent with other dts files around.
>
> DT doesn't define any kind of ordering for the properties AFAIK, so the
> order shouldn't matter in practice; it conveys no semantic
> representation as far as the parsing code is concerned even if a human
> may be influenced otherwise:-)
Well, this is somehow similar to code, maybe not exactly in case of
ordering, but coding style and conventions. Unreadable code can do exactly
the same thing as readable code, while we somehow prefer the readable one.
> Just as an FYI, the rule I've been trying to follow in Tegra DT files is
> that properties that are overridden from any included .dtsi file come
> first, followed by any new properties. Still, there's no particular
> reason anyone else has to follow that layout.
On Exynos I've been trying to keep status as the last property, compatible
as first, followed by reg and without any specific order of any other
properties. Again, this is simply to keep some consistence across the dtses
making them easier to read.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
