On Thu, 12 Sep 2013, Milo Kim wrote: > LP3943 has 16 output pins which can be used as GPIO expander and PWM generator. > > * Regmap I2C interface for R/W LP3943 registers > > * Atomic operations for output pin assignment > The driver should check whether requested pin is available or not. > If the pin is already used, pin request returns as a failure. > A driver data, 'pin_used' is checked when gpio_request() and > pwm_request() are called. If the pin is available, then pin_used is set. > And it is cleared when gpio_free() and pwm_free(). > > * Device tree support > Compatible strings for GPIO and PWM driver. > LP3943 platform data is PWM related, so parsing the device tree is > implemented in the PWM driver. > > Cc: Lee Jones <lee.jones@xxxxxxxxxx> > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Samuel Ortiz <sameo@xxxxxxxxxxxxxxx> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > Signed-off-by: Milo Kim <milo.kim@xxxxxx> > --- > * Patch v3 > Now, output pin number is exactly matched with enum value of ' > lp3943_pwm_output'. > Use dev_get_platdata() helper function in probe(). > Use module_i2c_driver() for initcall. > > * Patch v2 > Handle atomic operations for output pin assignment. > > drivers/mfd/Kconfig | 11 ++++ > drivers/mfd/Makefile | 1 + > drivers/mfd/lp3943.c | 148 ++++++++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/lp3943.h | 114 ++++++++++++++++++++++++++++++++++ > 4 files changed, 274 insertions(+) > create mode 100644 drivers/mfd/lp3943.c > create mode 100644 include/linux/mfd/lp3943.h Code looks good to me. For the MFD parts: Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
