Hi Sylwester, On Fri, Sep 6, 2013 at 1:32 AM, Sylwester Nawrocki <sylvester.nawrocki@xxxxxxxxx> wrote: > On 08/21/2013 08:34 AM, Arun Kumar K wrote: >> >> This patch adds subdev driver for Samsung S5K4E5 raw image sensor. >> Like s5k6a3, it is also another fimc-is firmware controlled >> sensor. This minimal sensor driver doesn't do any I2C communications >> as its done by ISP firmware. It can be updated if needed to a >> regular sensor driver by adding the I2C communication. >> >> Signed-off-by: Arun Kumar K<arun.kk@xxxxxxxxxxx> >> Reviewed-by: Sylwester Nawrocki<s.nawrocki@xxxxxxxxxxx> >> --- >> .../devicetree/bindings/media/i2c/s5k4e5.txt | 43 +++ >> drivers/media/i2c/Kconfig | 8 + >> drivers/media/i2c/Makefile | 1 + >> drivers/media/i2c/s5k4e5.c | 361 >> ++++++++++++++++++++ >> 4 files changed, 413 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/media/i2c/s5k4e5.txt >> create mode 100644 drivers/media/i2c/s5k4e5.c >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt >> b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt >> new file mode 100644 >> index 0000000..5af462c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/i2c/s5k4e5.txt >> @@ -0,0 +1,43 @@ >> +* Samsung S5K4E5 Raw Image Sensor >> + >> +S5K4E5 is a raw image sensor with maximum resolution of 2560x1920 >> +pixels. Data transfer is carried out via MIPI CSI-2 port and controls >> +via I2C bus. >> + >> +Required Properties: >> +- compatible : must be "samsung,s5k4e5" >> +- reg : I2C device address >> +- gpios : reset gpio pin > > > I guess this should be "reset-gpios". How about changing description to: > > - reset-gpios : specifier of a GPIO connected to the RESET pin; > > > ? If I name it to reset-gpios, the function of_get_gpio_flags() in the driver fails. This function searches for the entry with name "gpios". Is it still recommended to use a custom name and parse it explicitly? Regards Arun -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
